Closed
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shane32
commented
May 27, 2024
Shane32
commented
May 27, 2024
Shane32
commented
May 27, 2024
24 tasks
Co-authored-by: Benjie <[email protected]>
benjie
approved these changes
Jun 5, 2024
Member
benjie
left a comment
There was a problem hiding this comment.
Looks good to me, though some slight editorial on the wording to match the style of the spec as a whole might be warranted.
JoviDeCroock
approved these changes
Jun 7, 2024
Contributor
JoviDeCroock
left a comment
There was a problem hiding this comment.
This is a great validation rule 🙌
Member
|
The lack of this validation rule can be demonstrated in GraphQL.js with this: import { GraphQLSchema, GraphQLInt, graphql, GraphQLObjectType } from 'graphql';
const Query = new GraphQLObjectType({
name: 'Query',
fields: {
a: {
type: GraphQLInt,
resolve() {
return 42;
},
},
},
});
const schema = new GraphQLSchema({
query: Query,
});
const result = await graphql({ schema, source: `mutation { __typename }` });
console.dir(result);which produces: We should really mark this as an invalid request, and thus it should not have a |
Contributor
|
This is a refresh of #955 which has a pending PR at the implementation graphql/graphql-js#3601 |
yaacovCR
added a commit
to graphql/graphql-js
that referenced
this pull request
Dec 5, 2024
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : #3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 19, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 22, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to graphql/graphql-js
that referenced
this pull request
Dec 22, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : #3592
yaacovCR
added a commit
to graphql/graphql-js
that referenced
this pull request
Dec 22, 2025
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : #3592
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jan 27, 2026
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : graphql#3592
yaacovCR
added a commit
to graphql/graphql-js
that referenced
this pull request
Feb 22, 2026
New Spec PR: graphql/graphql-spec#1098 Old Spec PR: graphql/graphql-spec#947 Original issue raised by @benjaminjkraft : #3592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1097