! meaning compatability updated #1657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Criteria C has been clarified in #1659 to only relate to the unadorned type; if you wish to add that |
benjie
reviewed
Feb 20, 2025
Comment on lines
+500
to
+501
| - 🚫 `Int` reatains its meaning across both modes, but `Int!` means | ||
| non-nullable in one mode, but semantic non-nullable in another. Only |
There was a problem hiding this comment.
"modes" here was referring to null bubbling enabled/disabled, and Int! always means semantic non-null when null bubbling is disabled, so all solutions would fail this criteria the same. As such, the commentary around Int! meaning has been removed from the criteria.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In option 3, the meaning and mechanics of a
!adorned type change when a document adopts semantic nullability