Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trusted x11 forwarding with client xauth data #48937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Nov 13, 2024

Previously, tsh ssh -Y assumed that there was no required xauth data set for the current client $DISPLAY. This is usually the case for local XServers, which will default to connecting with local authentication mechanisms. However, in each x11 forwarding server jump, we set some fake xauth data for client-server authentication. This fake xauth data must be propogated to the next server jump, or else the client will fail to connect to the XServer proxy, leading to this error: X11 connection rejected because of wrong authentication..

This PR updates tsh to use existing xauth data when found, instead of always defaulting to creating new fake xauth data. Note that this now properly matches the openSSH implementation.

Fixes #48920

Changelog: Fix tsh ssh -Y when jumping between multiple servers.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48937.d3pp5qlev8mo18.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsh ssh -Y doesn't work for server jumps
1 participant