feat: Update URL to allow user to complete WebAuthn registration in app #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashraf706
requested review from
tcompiegne,
leleueri,
TrikyGeeky and
remisultan
remisultan
approved these changes
Jan 31, 2022
ashraf706
force-pushed
the
issues/#6834-add-self-account-webauthn-endpoints
branch
from
35597fe
to
fc4e5e8
Compare
ashraf706
force-pushed
the
issues/#6834-add-self-account-webauthn-endpoints
branch
from
fc4e5e8
to
042ae5b
Compare
remisultan
reviewed
Mar 14, 2022
...avitee/am/gateway/handler/root/resources/endpoint/webauthn/WebAuthnResponseEndpointTest.java
Show resolved
Hide resolved
ashraf706
force-pushed
the
issues/#6834-add-self-account-webauthn-endpoints
branch
from
042ae5b
to
99e64fe
Compare
ashraf706
force-pushed
the
issues/#6834-add-self-account-webauthn-endpoints
branch
from
99e64fe
to
f944d01
Compare
ashraf706
requested review from
remisultan and
farmborough
and removed request for
TrikyGeeky
The returnUrl/skipAction is determined by the presence of the url in the token. The token is send via "registration_token" param. The "registration_token" parameter is introduced to distinguished in between self service and regular registration.
ashraf706
force-pushed
the
issues/#6834-add-self-account-webauthn-endpoints
branch
from
f944d01
to
fba15b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: gravitee-io/issues#6834
The returnUrl/skipAction is determined by the presence of "self_registration" query param.
The "self_registration" parameter is introduced to distinguished in between self service and regular registration.