fix: propagate WS subprotocols from sec-websocket-protocol header for v4 APIs

[vikrantgravitee]

Issue

https://gravitee.atlassian.net/browse/APIM-11807

Description

• Ensure WebSocket subprotocols are set based on the sec-websocket-protocol header, mirroring V2 API behavior
• Fix endpoint value in v4-request log for better observability

Additional context

[gemini-code-assist]

Summary of Changes

Hello @vikrantgravitee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where WebSocket subprotocols were not being correctly propagated in V4 APIs, leading to inconsistent behavior compared to V2 APIs. It introduces changes to parse the sec-websocket-protocol header and apply the specified subprotocols to WebSocket connections. Additionally, it refines the logging of endpoint URIs for WebSocket connections to improve observability.

Highlights

• WebSocket Subprotocol Propagation: Implemented logic to correctly read and propagate WebSocket subprotocols from the sec-websocket-protocol header for V4 APIs, ensuring consistency with V2 API behavior.
• Improved Logging Observability: Fixed the endpoint value reported in v4-request logs by constructing a proper WebSocket URI, enhancing observability for WebSocket connections.
• Refactoring for Access: Modified the HttpConnector class to make defaultHost and defaultPort accessible to subclasses, facilitating the construction of WebSocket URIs in WebSocketConnector.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two main changes: propagating WebSocket subprotocols from the sec-websocket-protocol header and fixing the endpoint URI in logs for v4 WebSocket APIs. The implementation for parsing subprotocols is robust, handling multiple headers and comma-separated values correctly. The endpoint URI construction also appears correct. My main feedback is a suggestion to improve encapsulation by using protected getters instead of changing field visibility from private to protected, which is a better long-term design choice. Overall, the changes are well-implemented and address the described issues.