Skip to content

refactor(gateway): create abstractions #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

phiz71
Copy link
Member

@phiz71 phiz71 commented Oct 25, 2024

Issue

N/A

Description

Creates:

  • AbstractReactorFactory
  • AbstractPolicyChain
  • AbstractPolicyChainFactory

Use the abstractions in Http classes

@phiz71 phiz71 force-pushed the improve-gateway-reactor branch from c2440be to b6a9eca Compare October 25, 2024 21:40
Copy link
Contributor

@ytvnr ytvnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@phiz71 phiz71 force-pushed the improve-gateway-reactor branch from b6a9eca to 5be41a8 Compare November 4, 2024 16:22
@phiz71 phiz71 marked this pull request as ready for review November 4, 2024 16:22
@phiz71 phiz71 requested a review from a team as a code owner November 4, 2024 16:22
@phiz71 phiz71 force-pushed the improve-gateway-reactor branch 2 times, most recently from 0dd9a40 to 6de2a29 Compare November 7, 2024 14:32
@phiz71 phiz71 marked this pull request as draft November 12, 2024 09:21
Creates:
 - AbstractSecurityPlan
 - AbstractSecurityChain
 - AbstractReactorFactory
 - AbstractPolicyChain
 - AbstractPolicyChainFactory
@phiz71 phiz71 force-pushed the improve-gateway-reactor branch from 6de2a29 to 2325244 Compare November 21, 2024 11:56
@phiz71 phiz71 marked this pull request as ready for review November 21, 2024 12:42
@phiz71 phiz71 enabled auto-merge (rebase) November 21, 2024 13:10
@phiz71 phiz71 merged commit a35b24c into master Nov 21, 2024
10 of 12 checks passed
@phiz71 phiz71 deleted the improve-gateway-reactor branch November 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants