refactor(gateway): create abstractions #9726
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiz71
force-pushed
the
improve-gateway-reactor
branch
from
c2440be
to
b6a9eca
Compare
jhaeyaert
reviewed
Oct 28, 2024
...lers-api/src/main/java/io/gravitee/gateway/reactive/handlers/api/security/SecurityChain.java
Outdated
Show resolved
Hide resolved
phiz71
commented
Nov 4, 2024
...-api/src/main/java/io/gravitee/gateway/reactive/handlers/api/security/plan/SecurityPlan.java
Outdated
Show resolved
Hide resolved
ytvnr
reviewed
Nov 4, 2024
.../src/main/java/io/gravitee/gateway/reactive/handlers/api/security/AbstractSecurityChain.java
Show resolved
Hide resolved
phiz71
force-pushed
the
improve-gateway-reactor
branch
from
b6a9eca
to
5be41a8
Compare
Comment on lines
+103
to
+107
| protected abstract Maybe<SecurityToken> extractSecurityToken(final C executionContext); | ||
|
|
||
| protected abstract Completable executeSecurityPolicy(final C ctx, final ExecutionPhase executionPhase); | ||
|
|
||
| protected abstract String getSelectionRule(String selectionRule); |
There was a problem hiding this comment.
Just to given another point of view. Another way to do it can be to create SecurityPlan<T extends BaseSecurityPolicy, C extends BaseExecutionContext> that take a parameter an object that respect the interface with this 3 methods.
This another way is a composition and is generally present better than inheritence.
But I don't know all history and context of this piece of code
phiz71
force-pushed
the
improve-gateway-reactor
branch
from
5be41a8
to
0dd9a40
Compare
Creates: - AbstractSecurityPlan - AbstractSecurityChain - AbstractReactorFactory - AbstractPolicyChain - AbstractPolicyChainFactory
phiz71
force-pushed
the
improve-gateway-reactor
branch
from
0dd9a40
to
6de2a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Creates:
Use the abstractions in
Httpclasses