feat: add metadata property to NodeInfos #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcusnieux
force-pushed
the
cj-2542-gateway-technical-id
branch
from
081d71a
to
437efce
Compare
guillaumelamirand
approved these changes
Nov 13, 2024
| @@ -172,4 +171,24 @@ private String getZone() { | |||
| private int getPort() { | |||
| return Integer.parseInt(environment.getProperty("http.port", environment.getProperty("jetty.port", "-1"))); | |||
| } | |||
|
|
|||
| private Map<String, String> getAdditionalInformation() { | |||
| Map<String, String> additionalInformation = new HashMap<>(); | |||
There was a problem hiding this comment.
The code could be using EnvironmentUtils.getPropertiesStartingWith with by example
EnvironmentUtils
.getPropertiesStartingWith(environment, "additionalInformation")
.entrySet()
.stream()
.filter(entry -> Objects.nonNull(entry.getValue()))
.collect(Collectors.toMap(entry -> entry.getKey().substring(key.length() + 4), entry -> String.valueOf(entry.getValue())));
where the yaml would look like :
additionalInformation:
- name1: value1
- name2: value2
gcusnieux
force-pushed
the
cj-2542-gateway-technical-id
branch
from
437efce
to
4cdec3e
Compare
gcusnieux
changed the title
gcusnieux
force-pushed
the
cj-2542-gateway-technical-id
branch
from
4cdec3e
to
5be1dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/CJ-2542
Description
For the upgrade of Cloud gateways 30 days after control plane upgrade EPIC we need to link data plane deployment and registered nodes on cockpit side cockpit.
This PR add a generic additionalInformation environment variable.
Another task on platform team side will add the deploymentId on addtionalInformation of dataPlane.
Additional context
Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:
7.0.0-cj-2542-gateway-technical-id-SNAPSHOT