Feat(core)/bump dep #178
Open
Feat(core)/bump dep #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingki
requested changes
Dec 10, 2024
packages/graz/src/types/wallet.ts
Outdated
| @@ -60,6 +65,19 @@ export type Wallet = Pick< | |||
| setDefaultOptions?: (options: KeplrIntereactionOptions) => void; | |||
| onAfterLoginSuccessful?: () => Promise<void>; | |||
| getKey: (chainId: string) => Promise<Key>; | |||
| getOfflineSigner: (chainId: string) => OfflineAminoSigner | OfflineDirectSigner; | |||
There was a problem hiding this comment.
should be OfflineDirectSigner & OfflineAminoSigner
| Keplr, | ||
| "enable" | "getOfflineSigner" | "getOfflineSignerAuto" | "getOfflineSignerOnlyAmino" | "signDirect" | "signAmino" | ||
| > & { | ||
| export type Wallet = Pick<Keplr, "enable" | "getOfflineSignerOnlyAmino" | "signAmino"> & { |
There was a problem hiding this comment.
let's not override getOfflineSigner, getOfflineSignerAuto, signDirect
There was a problem hiding this comment.
I use the same structure as Keplr type, but using the OfflineAminoSigner & OfflineDirectSigner directly from @cosmjs, because Keplr type still use Long instead of BigInt
codingki
reviewed
Dec 10, 2024
| @@ -80,6 +80,7 @@ export const getInitia = (): Wallet => { | |||
| pubKey: account.pubkey, | |||
| bech32Address: account.address, | |||
| address: rawAddress, | |||
| ethereumHexAddress: "", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Graz project to use the latest versions of wallets and CosmJS dependencies.