Skip to content

[MAINTENANCE] Remove altair<5 pin. #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kg005
Copy link

@kg005 kg005 commented Jun 13, 2024

Trying to remove the altair version pin (<5.0.0) - link to existing issue

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jun 13, 2024

‼️ Deploy request for niobium-lead-7998 rejected.

Name Link
🔨 Latest commit 6d37a0f

@gx-cla-bot
Copy link

gx-cla-bot bot commented Jun 13, 2024

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

@kg005
Copy link
Author

kg005 commented Jun 13, 2024

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Jun 13, 2024

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

@kg005
Copy link
Author

kg005 commented Jun 13, 2024

@cla-bot check

@Kilo59 Kilo59 added the dependencies PR or issue that updates a dependency label Jun 13, 2024
@Khagesh16
Copy link

bump, please update the altair dep

@ZakariaHili
Copy link

When this PR will be merged ?

@keviloper
Copy link

Will the PR be merged soon?

@kg005
Copy link
Author

kg005 commented Feb 4, 2025

Hey @ZakariaHili @keviloper , I started the PR as to check if removing dependency is enough as suggested in #9657 (comment).

I also tried to cover some failing tests but no luck. My lack of time prevents me from getting deeper and finishing it, so I am happy to hand over to anyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community dependencies PR or issue that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants