-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[MAINTENANCE] Resolve datetime deprecation warnings #11134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Resolve datetime deprecation warnings #11134
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
|
Name | Link |
---|---|
🔨 Latest commit | 2d22bcf |
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: emmanuel-ferdman |
for more information, see https://pre-commit.ci
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: emmanuel-ferdman |
thanks for the PR, @emmanuel-ferdman ! If you could sign the CLA and leave a |
@joshua-stauffer I think I signed it a while ago but I signed it again now |
@cla-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @emmanuel-ferdman , looks great - since you resolved the noqa
comment, we can remove the FIXME as well. Much appreciated!
Co-authored-by: Joshua Stauffer <[email protected]>
Co-authored-by: Joshua Stauffer <[email protected]>
Co-authored-by: Joshua Stauffer <[email protected]>
Co-authored-by: Joshua Stauffer <[email protected]>
for more information, see https://pre-commit.ci
looks like there is a unit test that will need to be updated as well |
Signed-off-by: Emmanuel Ferdman <[email protected]>
for more information, see https://pre-commit.ci
@joshua-stauffer should be good now, thanks for the review |
❌ 523 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
a3ead68
PR Summary
This small PR resolves the deprecation warnings on
datetime
in Python3.12+:invoke lint
(usesruff format
+ruff check
)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!