Skip to content

Add SQL Server support #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from

Conversation

fredwang1012
Copy link

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB], [MINORBUMP]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

stejin and others added 30 commits December 11, 2024 22:43
Copy link

netlify bot commented Jun 23, 2025

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7abd1ed

@gx-cla-bot
Copy link

gx-cla-bot bot commented Jun 23, 2025

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: fredwang1012, [email protected]

@fredwang1012
Copy link
Author

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Jun 23, 2025

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

@fredwang1012
Copy link
Author

@cla-bot check

@gx-cla-bot
Copy link

gx-cla-bot bot commented Jun 23, 2025

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

@fredwang1012
Copy link
Author

@cla-bot check

@fredwang1012 fredwang1012 changed the title Fredwang1012 Add SQL Server support Jun 23, 2025
@tyler-hoffman
Copy link
Contributor

tyler-hoffman commented Jun 24, 2025

Hey @fredwang1012 ! Thanks for the contribution! I have a couple requests

  • Can we break out the DataBricks updates to a separate PR?
  • Similar with the regex -> like functionality
  • We're striving for stronger typing in the codebase, so if possible, I'd like to see those Anys moved back to str. I think that should work, given that the quoted names type in sqlalchemy looks to subclass str
  • Can you add some testing around this functionality? https://github.com/great-expectations/great_expectations/tree/develop/tests/integration/data_sources_and_expectations/data_sources contains integration tests on specific data sources. If you add a test file for mssql, you should be able to use the existing MSSQLDatasourceTestConfig class following the pattern of other test files in this directory. If you need a hand, feel free to tag me or @wookasz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants