[BUGFIX] Disable init analytics as it was not really getting entirely disabled when specified on data context config

[jmcorreia]

It seems init_analytics is being executed even when people is disabling analytics.
Inside this execution, there seems to be a method self._get_oss_id() searching for a root location cls._ROOT_CONF_FILE.exists() which is producing a permission denied error when used inside forEachBatch streaming on Databricks DBR15.4.

This PR proposes a fix to avoid invoking the init_analytics method if people disable it via config.

If there is other suggestion for a workaround, while this PR is not release, please let me know as this is a bit critical for us.

You can find more context below:

• Closes Ephemeral Data Context Failing with permission denied on file #11275 GitHub Issue: Ephemeral Data Context Failing with permission denied on file #11275
• Discourse topic: https://discourse.greatexpectations.io/t/ephemeral-data-context-failing-with-permission-denied-on-file/2235

[netlify]

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	82e90e8

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[gx-cla-bot]

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: [email protected]

[wookasz]

Thanks for the contribution. This looks reasonable. However, there are a few places in the code where init_analytics is invoked. Would you be willing to wrap these other calls in a similar check? If not we can follow up with that later.

Secondly, and this is where I'm requesting changes, the tests do need a little refactoring. test_analytics_enabled_on_load is no longer an appropriate name for the test method (it probably wasn't in the first place). Since we need to explicitly ensure that init_analytics is not called, there should be tests to assert that it is not called when the expected_value is False.

Let me know if you have any questions

[jmcorreia]

thanks for the feedback @wookasz . I have renamed one test and also enhanced it (and 1 more) to capture when it should be enabled and invoke init_analytics and when not.
I did not find more places where you would need to wrap init_analytics with the if statement. In any case, I have moved the if block inside the init_analytics method so you don't need to replicate the if statement in case it needs to be used in more places.
Also moved the try except block to cover possible permission denied or other errors while checking file existence when init_analytics is enabled.
Let me know if anything else is required.