-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applets: add a bi-directional bulk_speed_test applet #205
applets: add a bi-directional bulk_speed_test applet #205
Conversation
A couple of comments:
|
791498f
to
b9fb032
Compare
I've removed the vendor request handler without any ill-effects, tx! Let's wait for #207 to get merged into main and then I'll update the PR to match the new code layout. |
808a43c
to
54d489d
Compare
54d489d
to
8d3b6f7
Compare
I've rebased the PR to take #207 into account. Also:
|
0214a08
to
fb2c529
Compare
1772507
to
8b67e73
Compare
8b67e73
to
dc45dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! There's just a minor fix needed that I've added inline.
dc45dac
to
86572fd
Compare
This PR adds a new applet that is able to form a bi-directional bulk speed test.
I don't have access to SuperSpeed hardware so I thought it best to implement this separately to the
bulk_in_speed_test.py
applet for now.New features added:
There is one area where I am not 100% sure I'm doing the right thing in the gateware implementation and that is the logic for when a given IN or OUT test is inactive:
IN test:
https://github.com/antoinevg/luna/blob/791498f1eabb3632453770a5a3c5f7d3876e3c2a/applets/bulk_speed_test.py#L229-L236
OUT test:
https://github.com/antoinevg/luna/blob/791498f1eabb3632453770a5a3c5f7d3876e3c2a/applets/bulk_speed_test.py#L266-L270