Optimizations can get data without HTTP #1090
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
optimization_providers/base.py
Outdated
| #pylint: disable=dangerous-default-value | ||
| def run_reporters(run_id, repo_path, optimizations_ignore=[]): | ||
| def run_reporters(user_id, run_id, repo_path, optimizations_ignore=[]): |
There was a problem hiding this comment.
logic: Mutable default argument optimizations_ignore=[] can cause unexpected behavior if modified between calls
| def run_reporters(user_id, run_id, repo_path, optimizations_ignore=[]): | |
| def run_reporters(user_id, run_id, repo_path, optimizations_ignore=None): |
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -153,7 +153,7 @@ function prepare_config() { | |||
|
|
|||
| if [[ $modify_hosts == true ]] ; then | |||
|
|
|||
| local etc_hosts_line_1="127.0.0.1 green-coding-postgres-container" | |||
| local etc_hosts_line_1="127.0.0.1 green-coding-postgres-container green-coding-redis-container" | |||
There was a problem hiding this comment.
This will create 2 entries for 127.0.0.1 green-coding-postgres-container in the /etc/hosts file as the grep command will not find the line and then add it again (with the Redis part). Nothing serious
* main: (54 commits) Optimizations can get data without HTTP (#1090) Checking int fields for params and limiting retrieval amount (#1089) E-Mail now made optional Bump deepdiff from 8.2.0 to 8.3.0 (#1087) Bump psycopg-pool from 3.2.5 to 3.2.6 (#1081) Bump pytest from 8.3.4 to 8.3.5 (#1084) Bump fastapi[standard] from 0.115.8 to 0.115.11 (#1083) Update README.md - projects -> products Update README.md Updated gcb_playwright to 1.50.0 Will be build with 1.50.1 PR Bump psycopg-pool from 3.2.4 to 3.2.5 (#1078) Bump playwright/python in /docker/auxiliary-containers/gcb_playwright (#1072) Bump aiohttp from 3.11.12 to 3.11.13 (#1080) Bump psycopg[binary] from 3.2.4 to 3.2.5 (#1077) Bump cachetools from 5.5.1 to 5.5.2 (#1076) Updated Cloud Energy Typo Eco-CI now has a carbon badge in the repo overview [skip ci] (#1079) Updated Cloud Energy No asking for send ping in Codespaces; When asked though never send ping automatically ...
* Optimizations can get data without HTTP * Fix for immutable default argument [skip ci] * Redis now binds to local port to allow TCP connections - Used only in testing * Adding container to /etc/hosts
This PR introduces a fallback method that we plan to make the default for getting optimizations data.
It does not use the old HTTP transport mechanism, but queries the database directly.
Pros:
Downs:
Optimizations can still happen asynchronously if wanted on a different box
Greptile Summary
This PR modifies container name resolution to support direct database access for optimization data retrieval in shared environments, focusing on Redis container configuration and host file updates.
green-coding-redis-container) to localhost entry in/etc/hostsvialib/install_shared.sh127.0.0.1:6379indocker/compose.yml.examplefor network isolationtests/edit-etc-hosts.shto include Redis container hostname for testing