Guard clause against too old python version #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Eco CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
ArneTR
added a commit
that referenced
this pull request
Apr 20, 2025
* main: (22 commits) .github workflows yml typos Added removal of sudoers.d to uninstall script Division by zero protection for StdDev in charts Charts now display absolute StdDev [skip ci] (#1154) Added journalctl debug output Moving to undersampling debugging Eco CI for a while Guard clause against too old python version (#1153) Updated Cloud Energy Updated Cloud Energy Better error message in diff Frontend test fix mWh also in api helpers test Revert "Redirecting port 80 to SSL (#1141)" Update README.md Fixed tests for new mWh badge Moving to milli-watt hours (#1133) Runner now warns more prominently in dashboard when a run is marked as invalid Added note column to be sent to eco-ci (#1145) Set tabs to not active which were not active Adds the runner arguments as 'Switches' menu item to the stats.html (#1144) ...
ArneTR
added a commit
that referenced
this pull request
Apr 20, 2025
* main: (42 commits) .github workflows yml typos Added removal of sudoers.d to uninstall script Division by zero protection for StdDev in charts Charts now display absolute StdDev [skip ci] (#1154) Added journalctl debug output Moving to undersampling debugging Eco CI for a while Guard clause against too old python version (#1153) Updated Cloud Energy Updated Cloud Energy Better error message in diff Frontend test fix mWh also in api helpers test Revert "Redirecting port 80 to SSL (#1141)" Update README.md Fixed tests for new mWh badge Moving to milli-watt hours (#1133) Runner now warns more prominently in dashboard when a run is marked as invalid Added note column to be sent to eco-ci (#1145) Set tabs to not active which were not active Adds the runner arguments as 'Switches' menu item to the stats.html (#1144) ...
ArneTR
added a commit
that referenced
this pull request
Apr 21, 2025
* main: (43 commits) (fix/improvement): Time Travel mode was not correctly advancing step in error case; Reduced complexity of Time Travel code (fix): ee-branch must be string and checked as such Timeline badges rework (#1158) Adds the option to use --ee-branch as parameter. (#1123) Bump aiohttp from 3.11.14 to 3.11.16 (#1139) Machine names have now nice names in Dashboard and some QoL (#1142) Bump pydantic from 2.10.6 to 2.11.3 (#1143) Bump uvicorn[standard] from 0.34.0 to 0.34.1 (#1147) Fix invalid run markers (#1157) .github workflows yml typos Added removal of sudoers.d to uninstall script Division by zero protection for StdDev in charts Charts now display absolute StdDev [skip ci] (#1154) Added journalctl debug output Moving to undersampling debugging Eco CI for a while Guard clause against too old python version (#1153) Updated Cloud Energy Updated Cloud Energy Better error message in diff Frontend test fix ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Added Python version compatibility checks to ensure Green Metrics Tool requires Python 3.10 or higher, with consistent version checking implemented in both shell and Python environments.
check_python_version()function in/lib/install_shared.shto validate Python version during installation/lib/venv_checker.pyto include version check and standardize error codes from -1 to 1venv_checker.pyfor consistency