Cluster Cleanup Rework #1155
Merged
Cluster Cleanup Rework #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
* main: .github workflows yml typos Added removal of sudoers.d to uninstall script
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* main: (179 commits) Statistical significance is now 10 runs Updated Cloud Energy Upgraded pandas Bump redis from 6.1.0 to 6.2.0 (#1204) Bump cachetools from 5.5.2 to 6.0.0 (#1202) Bump uvicorn[standard] from 0.34.2 to 0.34.3 (#1210) Bump pytest from 8.3.5 to 8.4.0 (#1211) Bump python from 3.13.3-slim-bookworm to 3.13.4-slim-bookworm in /docker (#1220) Bump aiohttp from 3.11.18 to 3.12.12 (#1221) Bump requests from 2.32.3 to 2.32.4 in /docker (#1222) Clarified that index.html amounts of data points are user specific Keyboard interrupt locally does also not need to lead to error Keyboard Interrupt does not need to be alerted in cluster. Is either systemd or manual Logout now also inline message; Using dedicated login/logout icons Login successful more clear Notes sent by Eco Ci now shown in frontend (#1218) Sleep time cluster (#1217) Rounding with two digits Wrong branch for bakerydemo Updated CloudEnergy ...
…mplified set_status
There was a problem hiding this comment.
235 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Extensive system maintenance refactoring that migrates cluster cleanup from Bash to Python, adds NTP synchronization, and standardizes metric provider interfaces across the codebase.
/tools/cluster/cleanup_original.pywith improved error handling for APT updates and NTP synchronization/metric_providers/for better consistency/lib/job/,/api/scenario_runner.py, and related components for more flexible test configurations/lib/system_checks.pyand improved machine temperature management/docker/structure.sqlfor usage scenario variables, sampling rates, and machine changelog tracking