-
Notifications
You must be signed in to change notification settings - Fork 31
Usage Scenario Variables and ScenarioRunner templates #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ribalba How do you like these modes? Do they fulfill your idea of an easy mode? I am keeping the templates in the GMT repository and thus they are automatically versioned. To not muddy the overview of which version they have been changed in the GMT now overloads the commit-hash with the actual folder of the templates. Thus a change to the AI template will still keep the same commit_hash for the website template and vice versa. |
* main: Root DIR of GMT was not accurate Renamed Runner to ScenarioRunner and moved to lib/ Software add now returns job_id on insert; Jobs API now allows filter for job_id [skip ci] (#1170)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
23 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile
Old Energy EstimationEco CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
29 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Eco CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
* main: (27 commits) Bump orjson from 3.10.16 to 3.10.18 (#1168) Bump pydantic from 2.11.3 to 2.11.4 (#1169) Bump psycopg[binary] from 3.2.6 to 3.2.7 (#1171) Resource limits now also from services key; Added tests (#1173) (fix): Cron job queue check logic was reversed Updated ee Moving [system] and [machine] to upper case Shortened model Watchlist must insert usage_scenario_variables Comment for MCP Job ID now a field to filter by Usage Scenario Variables and ScenarioRunner templates (#1172) Disabled providers are now removed also from DB entry not only from effective measurement (fix): Entries for config options that were null where not correctly showing Made temperatur error more helpful Typo Root DIR of GMT was not accurate Renamed Runner to ScenarioRunner and moved to lib/ Software add now returns job_id on insert; Jobs API now allows filter for job_id [skip ci] (#1170) (test-fix): New wording ...
Adds measurement templates for beginners and quick measurements with GMT.
YOu can now do:
./run-template website "https://www.google.de"
./run-template ai "How cool is the GMT?"
This makes the tool more beginner friendly, but also abstracts away some of the pitfalls that are happing with measuring these two cases for instance that for both you need to have sensible providers active and for websites the resolution should be at least 1/10 of the page load time (typically 10 ms)
We will iterate on these modes and add warnings / guard-clauses as needed, but will have them as bare like this for the moment.
Greptile Summary
Added measurement templates and usage scenario variables to enable quick website and AI measurements, with significant updates to the ScenarioRunner and API endpoints.
usage_scenario_variables
JSONB column to runs, jobs, and watchlist tables with proper constraints/v2/jobs
and/v2/runs
endpoints, deprecating v1 versions with backward compatibilityshell=True