Shm size #1184
Merged
Shm size #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
|
Eco CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
ArneTR
added a commit
that referenced
this pull request
May 15, 2025
* main: (68 commits) Guard clause that runner.run_until may never be used without a context Software add now accepts but logs unknown endpoints other than GitHub and GitLab Added volumes key allow_unsafe and skip_unsafe technically usable via configuration. Not exposed Bump psycopg[binary] from 3.2.8 to 3.2.9 (#1188) Bump redis from 5.2.1 to 6.1.0 (#1187) Added statistical significance schedule mode [skip ci] (#1186) Bump deepdiff from 8.4.2 to 8.5.0 (#1181) Bump pylint from 3.3.6 to 3.3.7 (#1175) Adding dev-no-sleeps and dev-no-optimization to the cluster (#1185) Shm size (#1184) Shutdown in the cluster happens now dynamically depending on what is configured in shutdown_on_job_no Memory resource limits may also be plain int or float\nWill then be interpreted as bytes Bump playwright/python in /docker/auxiliary-containers/gcb_playwright (#1174) Bump psycopg[binary] from 3.2.7 to 3.2.8 (#1183) Bump hiredis from 3.1.0 to 3.1.1 (#1182) Temperature errors are reset now inline (fix): Version is allowed to be int, float or datetime too Added --dev-no-save flag (#1179) Removed duplicate ln ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds support for Docker shared memory (SHM) size configuration and improves resource limit validation, including handling of null values for CPU and memory limits in container configurations.
shm_sizein both string ('30MB') and byte (15728640) formats in/lib/scenario_runner.py/lib/schema_checker.py/tests/data/usage_scenarios/resource_limits_cpu_none.ymlbetween service definition and flow section/tests/data/usage_scenarios/resource_limits_shm_good.ymlfor SHM configurationscpus: nullconfiguration inresource_limits_cpu_none.ymlwhich violates schema requirements