Skip to content

Previous exception rework #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2025
Merged

Previous exception rework #1199

merged 4 commits into from
May 24, 2025

Conversation

ArneTR
Copy link
Member

@ArneTR ArneTR commented May 24, 2025

Greptile Summary

This PR improves exception handling and error reporting across the Green Metrics Tool codebase, focusing on better error communication and process management.

  • Unified exception handling in run.py, jobs.py, and client.py with clearer parameter names (exception_context/last_exception) and more detailed error information
  • Enhanced process management in scenario_runner.py with better tracking of detached processes and unified output handling
  • Simplified test scenarios by replacing stress tests with no-op tests in setup_commands_noop.yml and related files
  • Improved error message formatting with better structure and links to logs for user notifications
  • Modified website testing scenario to be more lenient with modern web caching patterns

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

* main:
  Moving to Chromium and squid with curl for healthcheck
  Proper detached feature log parsing and process handling for setup-commands (#1198)
  Update website-tester.yml
  Update website-tester.yml
  Update website-tester.yml
  Update website-tester.yml
  Update website-tester.yml
  Update website-tester.yml
  Update website-tester.yml
  Added website-tester test
@ArneTR ArneTR merged commit f12faaa into main May 24, 2025
@ArneTR ArneTR deleted the previous-exception-rework branch May 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant