-
Notifications
You must be signed in to change notification settings - Fork 43
Repository relations #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository relations #1509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 2 comments
| cwd=relation_path, | ||
| ) | ||
|
|
||
| if problematic_symlink := utils.find_outside_symlinks(relation_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you do this after the checkout runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository can contain symlinks. e.g. it possible to have a dangling symlink to /etc/passwd in the repo
|
Eco CI Output [RUN-ID: 20748001570]: 🌳 CO2 Data: Total cost of whole PR so far:
|
|||||||||||||||||||||||||||||||||||
Greptile Summary
Adds repository relations feature allowing measurement runs to checkout and mount additional repositories into containers. This enables multi-repository testing scenarios.
Key Changes:
relationsjsonb column torunstable to store relation metadata_checkout_relations()method clones related repositories to/tmp/relations/and mounts them into containers at/tmp/relations/{relation_key}:ro-itflags from docker run commands (now only uses-d)Issues Found:
commit_hashfield not escaped in frontend HTML insertion (stats.js:162)-itflag that was removed