Expert compare mode simple

[ArneTR]

Expert compare mode is now always visible via dropdown instead of separate activation in the settings.

default mode is auto.

Greptile Overview

Greptile Summary

This PR simplifies the expert compare mode feature by making it always visible via a dropdown on the runs page, rather than requiring activation in settings. The changes include:

Frontend Changes:

• Removed the expert compare mode toggle from the settings page (settings.html and settings.js)
• Added a Semantic UI accordion dropdown for compare mode selection on the runs page (runs.html)
• Changed the default option from "--" to "Auto" for better UX
• Updated localStorage key from expert_compare_mode_last_value to compare_mode_last_value

Test Updates:

• Updated test_runner.py to reflect changes from PR Oom better error #1514 (MemoryError for OOM container failures)

Issues Found:

1. Critical: Missing accordion initialization will cause JavaScript errors when trying to open/close the compare mode dropdown
2. Dead code: Conditional checks for localStorage.getItem('compare_mode') that is never set
3. Breaking tests: Two frontend tests reference removed UI elements and will fail

[ArneTR]

@greptileai

[greptile-apps]

_{4 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (2)

tests/frontend/test_frontend.py
This test (test_expert_compare_mode) will fail because it references UI elements that were removed in this PR. Specifically:

• Line 563: #expert-compare-mode element no longer exists (removed from settings.html)
• Line 565: #toggle-expert-compare-mode button no longer exists (removed from settings.html)
• Line 568: #expert-compare-mode element check will fail

The test needs to be updated to reflect the new UI where compare mode is always visible as a dropdown on the runs page, rather than being a toggle in settings. The test should now:

1. Navigate directly to the runs page
2. Select runs to enable the compare mode dropdown
3. Test the dropdown functionality directly without visiting settings

---

tests/frontend/test_frontend.py
This test (test_new_usage_scenario_variables_compare_mode) will also fail for the same reason as test_expert_compare_mode. It references:

• Line 624: #expert-compare-mode element (removed)
• Line 626: #toggle-expert-compare-mode button (removed)
• Line 629: #expert-compare-mode element check (removed)

The test needs to be updated to skip the settings page interaction and work directly with the compare mode dropdown on the runs page.

[ribalba]

Really like that change.

[greptile-apps]

Required keyword not found in PR title or description.