Adding network to SCI and clarifications #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneTR
added a commit
that referenced
this pull request
May 30, 2024
* main: Client.py error for docker commands Adding network to SCI and clarifications (#793)
ArneTR
added a commit
that referenced
this pull request
Jun 3, 2024
* main: (60 commits) Adds a script to remove carbonDB duplicates (#799) Bump uvicorn[standard] from 0.30.0 to 0.30.1 (#801) Power per container (#795) Wrong verb Removed more permissions Moved to suspend Reducing workflow permissions (#797) Moving our workflows to Ubuntu 24.04 because Docker Engine is too old in 22.04 (#794) Typo Client.py error for docker commands Adding network to SCI and clarifications (#793) Bump requests from 2.32.2 to 2.32.3 (#791) Added sorting by date and unified ci and measurement runs frontend (#769) Bump pydantic from 2.7.1 to 2.7.2 (#789) macOS test compatibility Relaxed tests more to accomodate for different startup times on slower machines Relaxed tests Uvicorn worker (#788) Bump uvicorn[standard] from 0.29.0 to 0.30.0 (#787) Add test with missing start_period ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the network CO2 to the calculation of the SCI.
Before network CO2 was treated separately. After a conversation with @mrchrisadams we decided to add it to the default SCI calculation and also make this more clear through a documentation page.
Clicking on "see details" next to the value brings you to https://docs.green-coding.io/docs/measuring/sci/#formula where it is made clear what goes into the SCI.