Skip to content

Allow to use ignore_pagination for get_tasks #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bjoernricks
Copy link
Contributor

What

Allow to use ignore_pagination for get_tasks

Why

GMP has the ignore_pagination attribute for getting a list of tasks. Add the argument to python-gvm too.

References

#1138

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team June 17, 2024 13:46
@bjoernricks bjoernricks enabled auto-merge (rebase) June 17, 2024 13:46
Copy link

github-actions bot commented Jun 17, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 16bf454.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (2349792) to head (9468b77).

Current head 9468b77 differs from pull request most recent head 16bf454

Please upload reports for the commit 16bf454 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          65       65           
  Lines        4541     4543    +2     
  Branches      831      832    +1     
=======================================
+ Hits         4431     4433    +2     
  Misses         74       74           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GMP has the ignore_pagination attribute for getting a list of tasks. Add
the argument to python-gvm too.

Closes #1138
@y0urself y0urself force-pushed the get-tasks-ignore-pagination branch from 9468b77 to 16bf454 Compare June 18, 2024 07:27
@bjoernricks bjoernricks merged commit 2bc27a2 into main Jun 18, 2024
19 checks passed
@bjoernricks bjoernricks deleted the get-tasks-ignore-pagination branch June 18, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants