Rename deep_merge to avoid conflicts with Rails#3
Open
skemtoputaete wants to merge 1 commit intogreensms-io:mainfrom
Open
Rename deep_merge to avoid conflicts with Rails#3skemtoputaete wants to merge 1 commit intogreensms-io:mainfrom
skemtoputaete wants to merge 1 commit intogreensms-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby on Rails framework implements Hash#deep_merge method. When GreenSMS is used with Rails it changes expected behavior. Renaming of Hash#deep_merge to Hash#merge_deep saves the clear name and helps to avoid possible problems for Rails-developers.