Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd_gpu: select device automatically #1935

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

MaxVerevkin
Copy link
Collaborator

Resolves #1928

@ammgws
Copy link
Collaborator

ammgws commented Aug 14, 2023

I was bit by #1935 too, but on my system I have an Intel iGPU which is at card0, so even with this fix the automatic selection would be wrong. I guess you only have one GPU and it is card1?

Wonder if we can check any of the other properties in /sys/class/drm/card0x to prefer ones that say 'AMD' or something. Though that still might not be perfect if your iGPU was AMD

@MaxVerevkin
Copy link
Collaborator Author

I guess you only have one GPU and it is card1?

Yes.

Wonder if we can check any of the other properties in /sys/class/drm/card0x to prefer ones that say 'AMD' or something.

That would be nice. rg -i amd /sys/class/drm/card1/device/ showed a few results, /sys/class/drm/card1/device/uevent is probably the best. On my system it has a line DRIVER=amdgpu.

I'm not aware of a way to check if a given GPU is integrated or not.

src/blocks/amd_gpu.rs Outdated Show resolved Hide resolved
@MaxVerevkin MaxVerevkin merged commit 016ba95 into master Aug 22, 2023
22 checks passed
@MaxVerevkin MaxVerevkin deleted the amd_gpu_select_device branch August 22, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amd_gpu: select device automatically
2 participants