Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather(metno): weathericon API was terminated, use pre-fetched data #1940

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

MaxVerevkin
Copy link
Collaborator

Fixes #1939

Copy link
Collaborator

@bim9262 bim9262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bim9262
Copy link
Collaborator

bim9262 commented Sep 2, 2023

We may want to note that as of August 31, 2023 all older versions of i3-status will be unable to use weather from metno

@MaxVerevkin
Copy link
Collaborator Author

We may want to note that as of August 31, 2023 all older versions of i3-status will be unable to use weather from metno

In the docs or release notes?

@bim9262
Copy link
Collaborator

bim9262 commented Sep 2, 2023

I'd just add that to the release notes. If someone notices that it doesn't work on their system they'll probably look at issues, pull requests, and the change log before going to the docs.

@MaxVerevkin MaxVerevkin merged commit 4397c39 into master Sep 2, 2023
22 checks passed
@MaxVerevkin MaxVerevkin deleted the fix-metno branch September 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weather(metno) "Legend replied in unknown format"
2 participants