Add Calendar block #2056

luca-iachini · 2024-05-16T17:41:14Z

This PR adds a Calendar block that displays upcoming events.

bim9262 · 2024-05-17T00:31:39Z

I'd suggest making this a calendar block and letting google be one of several providers, or perhaps use CalDAV by default since most calendars (including Google) support that.

luca-iachini · 2024-05-19T08:45:03Z

Hey @bim9262, thanks for the suggestion. I did not know the CalDav protocol. I'll try to push an implementation for that.

bim9262

It would be nice to be able to leverage https://crates.io/crates/caldav-utils, which seems to be the most used async caldav library, but it's missing oauth.

src/blocks/calendar.rs

src/blocks/calendar/caldav.rs

src/blocks/calendar.rs

src/blocks.rs

Cargo.toml

bim9262 · 2024-05-26T03:55:07Z

src/blocks/calendar.rs

+//! token_url = "https://oauth2.googleapis.com/token"
+//! auth_token = "~/.config/i3status-rust/calendar.auth_token"
+//! redirect_port = 8080
+//! scopes = ["https://www.googleapis.com/auth/calendar", "https://www.googleapis.com/auth/calendar.events"]


BTW, I would have thought that the readonly versions of the scopes would be valid. However that doesn't seem to be the case. I opened an issue about it: https://issuetracker.google.com/issues/342730758

luca-iachini · 2024-05-26T07:32:06Z

It would be nice to be able to leverage https://crates.io/crates/caldav-utils, which seems to be the most used async caldav library, blut it's missing oauth.

That would be nice. Unfortunately, I did not find Rust clients that support OAuth2 or have a way to intercept HTTP errors in a usable way.

bim9262

There's a lot of unwraps that should be handled too.

BTW good work on this, your contribution is appreciated :)

src/blocks/calendar.rs

luca-iachini · 2024-05-27T09:45:14Z

There's a lot of unwraps that should be handled too.

Ah yep, I forgot to properly handle those cases 😅 .

BTW good work on this, your contribution is appreciated :)

Thanks 😄

bim9262

Still seems like a lot of unwraps.
You'll need to rebase on master to fix the merge error.

Cargo.toml

MaxVerevkin · 2024-05-28T08:27:46Z

expect is not much better than unwrap, it still panics. Please use error.

luca-iachini · 2024-05-28T08:41:11Z

expect is not much better than unwrap, it still panics. Please use error.

I know both panic. I changed to expect the unwraps that cannot happen by design. Such as a url parsing unwrap from a hard-code string, HTTP method from a static string, .... Maybe, there is some that should be a proper error instead. Please, can you point those out?

Cargo.toml

src/blocks/calendar/auth.rs

src/blocks/calendar.rs

src/blocks/calendar/caldav.rs

cfsmp3 · 2024-06-01T05:04:56Z

Can you have more than one calendar source in the same block?
That would be my specific use case.

bim9262

Just 2 little changes to Cargo.toml, and we're set. I've tested it out and everything looks good to me.

Cargo.toml

bim9262 · 2024-10-19T19:27:41Z

Looks like Cargo.lock didn't get updated to reflect once_cell being removed.

bim9262 · 2024-10-19T21:47:06Z

Thanks @luca-iachini !!

luca-iachini marked this pull request as draft May 25, 2024 11:29

luca-iachini changed the title ~~Add Google Calendar block~~ Add Calendar block May 25, 2024

luca-iachini force-pushed the master branch 2 times, most recently from 824ee49 to 247513b Compare May 25, 2024 18:45

luca-iachini marked this pull request as ready for review May 25, 2024 18:45