block[weather]: Fix nws apparent temperature #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
australian_apparent_temp requires m/s not km/h. convert temperature back to fahrenheit if original temperature is in fahrenheit
|
Almost. There's one other possible issue, which is that other services using metric units use m/s for wind, whereas NWS will return km/h when metric units are requested. I'm not sure if that matters or not. |
|
Good call, I think it would be best to keep the speeds in standard units regardless of backend |
MaxVerevkin
reviewed
Jul 11, 2024
| @@ -177,8 +185,13 @@ impl ApiForecast { | |||
| (self.temperature.value - 32.0) * 5.0 / 9.0 | |||
| }; | |||
| let humidity = self.relative_humidity.value; | |||
| let wind_speed = self.wind_kmh(); | |||
| australian_apparent_temp(temp, humidity, wind_speed) | |||
| let wind_speed = self.wind_kmh() / 3.6; | |||
There was a problem hiding this comment.
Isn't this just = self.wind_speed();?
There was a problem hiding this comment.
Wind speed could be mph or m/s
There was a problem hiding this comment.
But wind_speed() is the function which you've added which always returns m/s? I think I misunderstood what these functions do. I think a few doc comments would be useful :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
australian_apparent_temp requires m/s not km/h.
convert temperature back to fahrenheit if original temperature is in fahrenheit
@Cognoscan does this capture the changes that you mentioned on your PR?