[fix] Updated the way default interfaces are chosen in netlink.rs#2151
Merged
MaxVerevkin merged 1 commit intogreshake:masterfrom Aug 2, 2025
Merged
[fix] Updated the way default interfaces are chosen in netlink.rs#2151MaxVerevkin merged 1 commit intogreshake:masterfrom
netlink.rs#2151MaxVerevkin merged 1 commit intogreshake:masterfrom
Conversation
netlink.rs
Contributor
|
@greshake sorry to bug you, but is there any chance this could get reviewed? In my case, this fixes my VPN block: [[block]]
block = "net"
device = ".*-wg-.*"
interval = 5
format = "{ $ip.str(w:0)$icon $device |}"
inactive_format = ""
missing_format = ""Given multiple VPN devices (where all but one are down):
|
Collaborator
|
Sorry for such a late response! This looks good to me, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr changes the way the default route and corresponding default interface are chosen
possible problem in issue 2117
What this fix does :
This should ensure that if multiple interfaces have “default routes,” the one with the lowest metric is chosen