Open
Conversation
This is functionally identical to `SDL_BLENDMODE_MOD` (https://wiki.libsdl.org/SDL_BlendMode). Multiplies colors, but leaves alpha alone. ``` SDL_BLENDMODE_MOD color modulate dstRGB = srcRGB * dstRGB dstA = dstA ```
Added GPU_BLEND_MULTIPLY_COLOR, which is functionally identical to SDL_BLENDMODE_MOD. Also omitted GPU_BlendPresetEnum initialization to make code cleaner and easier to edit, because compilers will default each enumerated value in the order defined as 0, 1, 2, etc just as before.
Owner
|
I'll take another look at this. The feature is a good one. The value initialization is intentional in order to preserve value compatibility. If a new value is added, it should not change the values of the ones that already exist unless a breaking change is acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
GPU_BLEND_MULTIPLY_COLOR, which is functionally identical toSDL_BLENDMODE_MOD(see https://wiki.libsdl.org/SDL_BlendMode).I also omitted value initialization from the
GPU_BlendPresetEnumenumerated list to make for quicker editing in the future. This is becauseis treated identically to
by compilers. The same code is generated, but it's now easier to add, say,
A2betweenAandBwithout having to manually go through and sayB=2andC=3now.I hope that makes sense and that this helps. Keep up the great work on this API!