-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Feature: allow user to permanently dismiss the "Asset not found" message #15227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature: allow user to permanently dismiss the "Asset not found" message #15227
Conversation
PR Summary
|
13a2e91 to
064745a
Compare
0a67fb3 to
c008f2e
Compare
|
I'm not 100% sure I see the use case here, but I think we'd want that dismiss link to be white so it's clearer. |
c008f2e to
18991c7
Compare
And to clarify the purpose, in our organization we are used to look for a specific asset tag, but also for other attributes (serial number, manufacturer, model, ...). As per our discussion in PR #15217, you're right, it makes sense to show the warning message. But if searching for other attributes is part of the user workflow, I think it would make sense to allow the user to ignore the warning message. To be honest, I'm not 100% convinced of the adhesion it would get from other users. If you wish, we can put this PR on hold/draft until it receives more attention from the community. |
|
Can I ask why??? We have several admins at different locations that they support. Sometimes assets get Transferred from one location to another. If an admin only has access to a certain company and they come across an asset that is not there's, it would be nice if the message would say "this asset [asset number] belongs to [company name]. Instead of permanently dismissing this message all together, can we incorporate some logic scenario messages if multi company support is enabled and for admins who only have access to certain companies? This would be a huge benefit to ensure that assets get returned to their proper locations without always having to puck up the phone and ask..."hey do you have this asset???" |
|
@brianhoganm calm down with the question marks lol - everybody has different workflows. I definitely would not want to disclose the name of the company the asset belongs to (MSPs might not want their other customer names exposed) but we would only do this on an individual level if we even go down this path. |
I would make this as an option to enable this in settings |
15a932f to
a39d687
Compare
|
The last commit a39d687 makes this feature available as a profile setting, instead of using the browser local storage. |




Description
Every time a user performs a search for a value that is not an asset tag, a warning message will show up mentioning the assset wasn't found. If such use of the search field is intentional, it would be good to allow the user to permanently dismiss the warning message.
Note: for the search feature, refer to PR #15217.
What changes
This PR gives the possibility to permanently dismiss the warning message shown when an asset tag doesn't exist.
Current proposition:

Remaining tasks
Type of change
How Has This Been Tested?
Checklist: