Skip to content

Improve Settings: Remove username and password requirement for ldap #16592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

fvollmer
Copy link
Contributor

@fvollmer fvollmer commented Mar 31, 2025

Since 9d62793 anonymous LDAP login is available. Remove username and password requirement in settings dialog.

@fvollmer fvollmer requested a review from snipe as a code owner March 31, 2025 10:52
Copy link

welcome bot commented Mar 31, 2025

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Mar 31, 2025

PR Summary

  • Removal of Validation Rules for Certain Fields
    The rules for checking validity of input data ('validation rules') for the fields ldap_uname and ldap_pword inside the StoreLdapSettings request have been removed. This provides more flexibility while inputting data in these fields.

@fvollmer fvollmer force-pushed the anonymous-ldap branch 3 times, most recently from 740fa00 to 5658979 Compare March 31, 2025 11:11
@fvollmer fvollmer changed the title Remove username and password requirement for anonymous LDAP login Improve Settings: Remove username and password requirement for ldap Mar 31, 2025
@snipe
Copy link
Member

snipe commented Apr 8, 2025

Hi there - thanks for this! Can you please re-target this PR to point to the develop branch, per our Contributing documentation?

You usually don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.

mhuxq

Thanks!

@fvollmer fvollmer changed the base branch from master to develop April 8, 2025 08:57
Since 9d62793 anonymous LDAP login is available. Remove username and password requirement in settings dialog.
@fvollmer
Copy link
Contributor Author

fvollmer commented Apr 8, 2025

I've retarget the pull request and rebased the commit onto the develop branch

@snipe snipe merged commit 1d030b5 into grokability:develop Apr 9, 2025
3 checks passed
Copy link

welcome bot commented Apr 9, 2025

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants