release: add a logger for release tasks #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: groongaGH-43 In this PR, we add a logger for release tasks. Our log will be output in `log/error.log`.
kou
reviewed
Dec 23, 2024
| @@ -94,7 +95,8 @@ def process_payload!(payload) | |||
| def deploy(payload) | |||
| Thread.new do | |||
| # TODO: call rake tasks for sign packages. | |||
| # TODO: write down the errors into log files. | |||
| rescue => e | |||
| Logger.log("error.log", e.message) | |||
There was a problem hiding this comment.
デプロイ処理はspawnで動かすからサブプロセスの標準出力と標準エラー出力を直接ログファイルにつなげたいかなー
There was a problem hiding this comment.
次のようなイメージでいるのですがあっていますか？
def deploy(payload)
...
Process.spawn(
release_rake_command,
out: "log/stdout.log",
err: "log/stderr.log"
)
endThere was a problem hiding this comment.
了解です。
Loggerは必要なさそうなので、closeしてリリース用のRakeタスクを呼ぶ部分の実装をします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-43
In this PR, we add a logger for release tasks.
Our log will be output in
log/error.log.