Transaction observers are not impacted by Task Cancellation #1747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the release of GRBD 7,
Task
cancellation interrupts asynchronous database accesses.This has created a problem with transaction observers. If a
Task
is cancelled after a transaction was successfully committed to disk, observers could fail processing the transaction.ValueObservation
, in particular, could not fetch fresh values, and report an error:This pull request restores the independence of transaction observers, and makes sure they can access the database even from a cancelled
Task
.Thank you @tgrapperon for reporting this issue in #1746