examples/features/opentelemetry: demonstrate tracing using OpenTelemetry plugin #8056

janardhanvissa · 2025-01-30T16:44:57Z

RELEASE NOTES:

examples/features/opentelemetry: modify example to demonstrate tracing using OpenTelemtry plugin.

codecov · 2025-01-30T16:51:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (ce35fd4) to head (f5828d3).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8056      +/-   ##
==========================================
- Coverage   82.16%   82.13%   -0.03%     
==========================================
  Files         410      410              
  Lines       40248    40248              
==========================================
- Hits        33068    33059       -9     
- Misses       5830     5833       +3     
- Partials     1350     1356       +6

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

examples/features/opentelemetry/client/main.go

examples/features/opentelemetry/server/main.go

purnesh42H

@janardhanvissa please use any of the trace exporter from here https://opentelemetry.io/docs/languages/go/exporters/. May be otlptracehttp or stdouttrace are good candidates

Also, please refer to https://opentelemetry.io/docs/languages/go/getting-started/ for writing otel trace exporting parts in client and server. We should try to avoid as much custom code as possible here to make it easy and fast for users to pick up.

examples/features/opentelemetry/client/main.go

examples/features/opentelemetry/server/main.go

examples/features/opentelemetry/client/main.go

examples/features/opentelemetry/server/main.go

examples/features/opentelemetry/client/main.go

purnesh42H

@janardhanvissa i discussed with @dfawley and we are fine with using console exporter instead for the tracing example so that we don't have install extra stufff. Please modify the example using the console exporter

examples/features/opentelemetry/client/main.go

examples/features/opentelemetry/server/main.go

vinothkumarr227 · 2025-02-27T07:29:04Z

examples/go.mod

+//
+// For the OpenTelemetry Collector Core distribution specifically, see
+// https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol
+


nit: // Documentation:
// The builder manifests used for official OpenTelemetry Collector binaries
// can be found at the following repository:
// https://github.com/open-telemetry/opentelemetry-collector-releases
//
// For the OpenTelemetry Collector Core distribution specifically, refer to:
// https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol

These docs are for the OpenTelemetry Collector, which we're not using; we're using stdouttrace instead. These things are already removed from the go.mod.

vinothkumarr227 · 2025-02-27T07:32:15Z

examples/features/opentelemetry/client/main.go

 	// the client and the server.
 	for {
 		r, err := c.UnaryEcho(ctx, &echo.EchoRequest{Message: "this is examples/opentelemetry"})
 		if err != nil {
 			log.Fatalf("UnaryEcho failed: %v", err)
 		}
 		fmt.Println(r)
+


nit: remove the extra space

vinothkumarr227 · 2025-02-27T07:33:54Z

examples/features/opentelemetry/server/main.go

@@ -51,14 +60,47 @@ func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.Echo
 }

 func main() {
+	flag.Parse()
+


nit: Remove the extra space and check the other places as well

vinothkumarr227 · 2025-03-27T09:19:19Z

examples/features/opentelemetry/README.md

-OpenTelemetry is configured on both the client and the server, and exports to
-the Prometheus exporter. The exporter exposes metrics on the Prometheus ports
-described above.
+OpenTelemetry is configured on both the client and the server, and exports metrics to the Prometheus exporter. The exporter exposes metrics on the Prometheus ports described above. OpenTelemetry also exports traces using the stdouttrace exporter. These traces are printed as structured data to the console output of both the client and the server.


Suggested change

OpenTelemetry is configured on both the client and the server, and exports metrics to the Prometheus exporter. The exporter exposes metrics on the Prometheus ports described above. OpenTelemetry also exports traces using the stdouttrace exporter. These traces are printed as structured data to the console output of both the client and the server.

OpenTelemetry is configured on both the client and the server, and exports metrics to the Prometheus exporter. The exporter exposes metrics on the Prometheus ports described above.

OpenTelemetry exports traces using the stdouttrace exporter, which prints structured trace data to the console output of both the client and server. Each RPC call produces trace information that captures the execution flow and timing of operations.

purnesh42H

@janardhanvissa in README.md, please all sentences to 80 cols.

purnesh42H · 2025-04-01T16:12:30Z

examples/features/opentelemetry/README.md

@@ -1,10 +1,13 @@
 # OpenTelemetry

-This example shows how to configure OpenTelemetry on a client and server, and shows
-what type of telemetry data it can produce for certain RPC's.
+This example shows how to configure OpenTelemetry on a client and server, and shows what type of telemetry data it can produce for certain RPC's.


Please restrict the sentences to 80 cols. What is the change here?

reached 80 cols, so moved to the next line.

purnesh42H · 2025-04-01T16:13:46Z

examples/features/opentelemetry/README.md


 ## Try it

+This section shows how to configure OpenTelemetry Metrics and Traces.


we can remove this I think. The first sentence is enough

purnesh42H · 2025-04-01T16:14:03Z

examples/features/opentelemetry/README.md


 ## Try it

+This section shows how to configure OpenTelemetry Metrics and Traces.
+
+**1. Run the gRPC Applications:**


same. No need of this

purnesh42H · 2025-04-01T16:14:09Z

examples/features/opentelemetry/README.md

@@ -13,20 +16,18 @@ go run server/main.go
 go run client/main.go
 ```

+**2. View Telemetry Data:**


no need of this

purnesh42H · 2025-04-01T16:15:44Z

examples/features/opentelemetry/README.md

-The client continuously makes RPC's to a server. The client and server both
-expose a prometheus exporter to listen and provide metrics. This defaults to
-:9464 for the server and :9465 for the client.
+The client continuously makes RPC's to a server. The client and server both expose a Prometheus exporter to listen and provide metrics. This defaults to :9464 for the server and :9465 for the client. The client and server are also configured to output traces directly to their standard output streams using stdouttrace.


wrap stdouttrace within backticks

purnesh42H · 2025-04-01T16:17:46Z

examples/features/opentelemetry/client/main.go

 )

 func main() {
-	exporter, err := prometheus.New()
+	flag.Parse()


do we need this flag.Parse()? or it can be removed?

purnesh42H · 2025-04-01T16:18:14Z

examples/features/opentelemetry/client/main.go

 	if err != nil {
 		log.Fatalf("Failed to start prometheus exporter: %v", err)
 	}
-	provider := metric.NewMeterProvider(metric.WithReader(exporter))
-	go http.ListenAndServe(*prometheusEndpoint, promhttp.Handler())
+	// Initialize MeterProvider with Prometheus exporter.


no need of this comment. Actually there is no change needed here. It can be reverted

purnesh42H · 2025-04-01T16:19:20Z

examples/features/opentelemetry/server/main.go

 )

 var (
 	addr               = flag.String("addr", ":50051", "the server address to connect to")
-	prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
+	prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint for metrics")
+	serviceName        = "grpc-server"


same. Do we need this? or it can be removed?

we need to set the service name as an attribute in the resource information attached to the traces for the server.

purnesh42H · 2025-04-01T16:19:33Z

examples/features/opentelemetry/server/main.go

@@ -51,14 +57,28 @@ func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.Echo
 }

 func main() {
-	exporter, err := prometheus.New()
+	flag.Parse()


same. do we need this? or it can be removed?

purnesh42H · 2025-04-01T16:19:55Z

examples/features/opentelemetry/server/main.go

 	if err != nil {
 		log.Fatalf("Failed to start prometheus exporter: %v", err)
 	}
-	provider := metric.NewMeterProvider(metric.WithReader(exporter))
-	go http.ListenAndServe(*prometheusEndpoint, promhttp.Handler())
+	// Initialize MeterProvider with Prometheus exporter.


same. No need of any change here. Let it be how it was.

…ent and server

purnesh42H

lgtm

purnesh42H · 2025-04-03T16:11:30Z

examples/features/opentelemetry/client/main.go

 )

 func main() {
 	exporter, err := prometheus.New()
 	if err != nil {
 		log.Fatalf("Failed to start prometheus exporter: %v", err)
 	}
-	provider := metric.NewMeterProvider(metric.WithReader(exporter))
-	go http.ListenAndServe(*prometheusEndpoint, promhttp.Handler())
+	provider := otelmetric.NewMeterProvider(otelmetric.WithReader(exporter))


nit: one comment above "Configure meter provider for metrics"

purnesh42H · 2025-04-03T16:11:45Z

examples/features/opentelemetry/client/main.go

+	if err != nil {
+		log.Fatalf("Failed to create stdouttrace exporter: %v", err)
+	}
+


nix new line

purnesh42H · 2025-04-03T16:11:53Z

examples/features/opentelemetry/client/main.go

+		log.Fatalf("Failed to create stdouttrace exporter: %v", err)
+	}
+
+	// Configure the tracer provider


can remove this

purnesh42H · 2025-04-03T16:13:33Z

examples/features/opentelemetry/client/main.go

+
+	// Configure the tracer provider
+	tp := sdktrace.NewTracerProvider(sdktrace.WithBatcher(traceExporter), sdktrace.WithResource(otelresource.NewWithAttributes(semconv.SchemaURL, semconv.ServiceName(serviceName))))
+	textMapPropagator := otelpropagation.TraceContext{} // Using W3C Trace Context Propagator.


Suggested change

textMapPropagator := otelpropagation.TraceContext{} // Using W3C Trace Context Propagator.

// Configure W3C Trace Context Propagator for traces

textMapPropagator := otelpropagation.TraceContext{} // Using W3C Trace Context Propagator.

purnesh42H · 2025-04-03T16:13:57Z

examples/features/opentelemetry/client/main.go


-	ctx := context.Background()
-	do := opentelemetry.DialOption(opentelemetry.Options{MetricsOptions: opentelemetry.MetricsOptions{MeterProvider: provider}})
+	// Initialize stdouttrace exporter for traces


replace comment with "Configure exporter for traces"

Suggested change

// Initialize stdouttrace exporter for traces

// Configure exporter for traces

purnesh42H · 2025-04-03T16:24:07Z

@janardhanvissa could you add the screenshots of traces on clients and server please?

janardhanvissa · 2025-04-03T17:42:02Z

@janardhanvissa could you add the screenshots of traces on clients and server please?

Server

Client

janardhankrishna-sai and others added 9 commits December 23, 2024 07:09

replace dial with newclient

7ddbe46

Merge branch 'master' of https://github.com/janardhanvissa/grpc-go

0486355

Merge branch 'grpc:master' into master

53fa9cd

Merge branch 'grpc:master' into master

4435b8a

Merge branch 'grpc:master' into master

a413555

Merge branch 'grpc:master' into master

4e203c3

Merge branch 'grpc:master' into master

e9ad552

adding opentelemetry tracing for client-server

61e15e3

adding opentelemetry tracing for client-server

4a988a6

purnesh42H reviewed Feb 5, 2025

View reviewed changes

purnesh42H assigned janardhanvissa Feb 5, 2025

addressing review comments

58451b6

janardhanvissa force-pushed the tracing-otel branch from f463f2b to 58451b6 Compare February 6, 2025 09:56

janardhankrishna-sai added 9 commits February 6, 2025 10:03

reverting Newclient changes

9ac7ce3

reverting Newclient changes

c0e8885

adding dependency files

0b4231a

removing unused ctx

b8c0ef5

fixing vet issue

a33cc4b

adding trace to client/server

6215e98

fix vet issue

c68e570

fixing vet issue

02d9139

removing empty lines

9db8ad6

purnesh42H assigned purnesh42H and unassigned janardhanvissa Feb 18, 2025

purnesh42H changed the title ~~opentelemetry: add open telemetry trace for client/server~~ examples/features/opentelemetry: Add example to demonstrate OpenTelemetry Tracing Feb 19, 2025

purnesh42H reviewed Feb 19, 2025

View reviewed changes

purnesh42H assigned janardhanvissa and unassigned purnesh42H Feb 19, 2025

janardhanvissa commented Feb 19, 2025

View reviewed changes

examples/features/opentelemetry/client/main.go Outdated Show resolved Hide resolved

purnesh42H added this to the 1.72 Release milestone Mar 24, 2025

janardhankrishna-sai added 3 commits March 25, 2025 06:43

addressing review comments

d12b4f3

rebase push

2ef0356

fixing vet issue

95398e1

purnesh42H reviewed Mar 25, 2025

View reviewed changes

examples/features/opentelemetry/client/main.go Outdated Show resolved Hide resolved

examples/features/opentelemetry/server/main.go Outdated Show resolved Hide resolved

janardhankrishna-sai added 4 commits March 27, 2025 08:46

updating exporter from otlp to stdouttrace

e861fbe

updating readme

1a36d58

updating readme

f63f1f6

updating readme

8c99dce

janardhanvissa requested a review from purnesh42H March 27, 2025 16:11

vinothkumarr227 reviewed Mar 27, 2025

View reviewed changes

janardhankrishna-sai added 2 commits March 28, 2025 03:16

addressing review comments

881f0e5

fixing vet issue

b129fa0

purnesh42H reviewed Apr 1, 2025

View reviewed changes

janardhankrishna-sai and others added 4 commits April 1, 2025 16:53

updating readme by wraping 80col perline and removing comment for cli…

3855e04

…ent and server

small tweak

7f2636c

small tweak

2e59ff7

Update README.md

56cf9ef

janardhanvissa requested a review from purnesh42H April 1, 2025 17:16

eshitachandwani modified the milestones: 1.72 Release, 1.73 Release Apr 3, 2025

purnesh42H approved these changes Apr 3, 2025

View reviewed changes

purnesh42H requested a review from dfawley April 3, 2025 16:14

purnesh42H assigned dfawley and unassigned janardhanvissa Apr 3, 2025

addressing review comments

b24b2fb

janardhanvissa and others added 2 commits April 4, 2025 11:09

Merge branch 'master' into tracing-otel

85c095b

deps

f5828d3

	OpenTelemetry is configured on both the client and the server, and exports metrics to the Prometheus exporter. The exporter exposes metrics on the Prometheus ports described above. OpenTelemetry also exports traces using the stdouttrace exporter. These traces are printed as structured data to the console output of both the client and the server.
	OpenTelemetry is configured on both the client and the server, and exports metrics to the Prometheus exporter. The exporter exposes metrics on the Prometheus ports described above.
	OpenTelemetry exports traces using the stdouttrace exporter, which prints structured trace data to the console output of both the client and server. Each RPC call produces trace information that captures the execution flow and timing of operations.


		## Try it

		This section shows how to configure OpenTelemetry Metrics and Traces.

	textMapPropagator := otelpropagation.TraceContext{} // Using W3C Trace Context Propagator.
	// Configure W3C Trace Context Propagator for traces
	textMapPropagator := otelpropagation.TraceContext{} // Using W3C Trace Context Propagator.

	// Initialize stdouttrace exporter for traces
	// Configure exporter for traces

examples/features/opentelemetry: demonstrate tracing using OpenTelemetry plugin #8056

Are you sure you want to change the base?

examples/features/opentelemetry: demonstrate tracing using OpenTelemetry plugin #8056

Conversation

janardhanvissa commented Jan 30, 2025 • edited by purnesh42H Loading

codecov bot commented Jan 30, 2025 • edited Loading

Codecov Report

purnesh42H left a comment

Choose a reason for hiding this comment

purnesh42H left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnesh42H left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnesh42H left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

purnesh42H commented Apr 3, 2025

janardhanvissa commented Apr 3, 2025

janardhanvissa commented Jan 30, 2025 •

edited by purnesh42H

Loading

codecov bot commented Jan 30, 2025 •

edited

Loading