Skip to content

xds: client outlier detection metrics [A91] #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PardhuKonakanchi
Copy link

@PardhuKonakanchi PardhuKonakanchi commented Jul 8, 2025

Implements A91 in grpc-go

Two counters have been added according to the gRFC within the outlier detection algorithm on either ejections or unenforced ejection.

Currently, grpc.lb.backend_service is an optional label with an empty string as per the design until A89 and A75 are both implemented in grpc-go, after which the string can be updated for these metrics.

Tests

Updating existing outlier detection balancer tests to check if ejection stats are measured

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (a21e374) to head (dc641b1).

Files with missing lines Patch % Lines
xds/internal/balancer/outlierdetection/balancer.go 61.11% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8437      +/-   ##
==========================================
+ Coverage   82.26%   82.31%   +0.05%     
==========================================
  Files         414      414              
  Lines       40410    40429      +19     
==========================================
+ Hits        33243    33281      +38     
+ Misses       5796     5787       -9     
+ Partials     1371     1361      -10     
Files with missing lines Coverage Δ
xds/internal/balancer/outlierdetection/balancer.go 86.36% <61.11%> (-2.43%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant