Skip to content

server: allow 0s grpc-timeout header values, as java is known to be able to send them #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 8, 2025

grpc/grpc-java#12201 was recently created to prevent this, but older versions will still do it. This reverts our old behavior of allowing 0 second timeouts (pre- #8290).

I would propose that we do not revert the change in http_util and allow the RPC to instantly timeout instead of throw an internal error.

cc @ejona86

RELEASE NOTES:

  • server: allow 0s grpc-timeout header values, which older gRPC-Java versions could send

@dfawley dfawley added this to the 1.75 Release milestone Jul 8, 2025
@dfawley dfawley requested a review from arjan-bal July 8, 2025 21:56
@dfawley dfawley added the Type: Behavior Change Behavior changes not categorized as bugs label Jul 8, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (a21e374) to head (3059358).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/transport/http2_server.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8439      +/-   ##
==========================================
+ Coverage   82.26%   82.34%   +0.07%     
==========================================
  Files         414      414              
  Lines       40410    40418       +8     
==========================================
+ Hits        33243    33281      +38     
+ Misses       5796     5774      -22     
+ Partials     1371     1363       -8     
Files with missing lines Coverage Δ
internal/transport/http_util.go 94.44% <ø> (-0.07%) ⬇️
internal/transport/http2_server.go 90.14% <0.00%> (-0.64%) ⬇️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Jul 9, 2025
@dfawley dfawley merged commit 12f9d9c into grpc:master Jul 9, 2025
17 checks passed
dfawley added a commit to dfawley/grpc-go that referenced this pull request Jul 9, 2025
dfawley added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants