xds: add a test for deadlocks in nested xDS channels #8448
Merged
+250
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Testing
Area: xDS
arjan-bal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8448 +/- ##
==========================================
+ Coverage 82.27% 82.35% +0.08%
==========================================
Files 414 414
Lines 40422 40436 +14
==========================================
+ Hits 33257 33301 +44
+ Misses 5799 5775 -24
+ Partials 1366 1360 -6 🚀 New features to boost your workflow:
|
dfawley
approved these changes
Jul 14, 2025
| @@ -19,18 +19,34 @@ | |||
| package pool_test | |||
There was a problem hiding this comment.
Aside: it seems this file should have been named pool_ext_test.go to prepare for the day we might want pool_test.go that is inside package pool.
There was a problem hiding this comment.
Renamed the file and package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to catch deadlocks when using xDS to resolve the address of the xDS management server, resulting in the creation of nested xDS channels. The fix for the bug was initially submitted in #8011 and later in #8445.
Tested
Verified that the deadlock can be reproduced in 2-3 runs when the fix in #8445 is not included. The deadlock is resolved after including #8445.
RELEASE NOTES: N/A