feat: add the missing xds.authority label #12018
Merged
+80
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a as in the existing flow 2. xds: modifies existing tests to account for authority
ejona86
reviewed
Apr 15, 2025
|
@AgraVator, you've copied/rebased commits from master to this PR. That's broken. Those need to be removed; I'd normally do "git rebase -i" and deleting the lines for the commits you didn't create. But I don't know what operation you did and why. |
AgraVator
force-pushed
the
add-xds-authority-label
branch
from
da6df80 to
ecf8e55
Compare
2. xds: considers authority as a separate dimension
AgraVator
force-pushed
the
add-xds-authority-label
branch
from
ecf8e55 to
9ed94ac
Compare
ejona86
reviewed
Apr 21, 2025
ejona86
approved these changes
Apr 21, 2025
2. xds: move getAuthorityFromResourceName() near other static methods
2. xds: move getAuthorityFromResourceName() near other static methods
xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java
Outdated
Show resolved
Hide resolved
xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java
Outdated
Show resolved
Hide resolved
xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java
Outdated
Show resolved
Hide resolved
xds/src/test/java/io/grpc/xds/XdsClientMetricReporterImplTest.java
Outdated
Show resolved
Hide resolved
kannanjgithub
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to complete the XDS client metrics by adding the remaining grpc.xds.authority metric.