Skip to content

Conversation

@shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Jul 17, 2025

Reverts #12063

CSDS will crash if we don't update the 1:1 mapping with new status that has been defined by gRFC A88 in another section.

static ClientResourceStatus metadataStatusToClientStatus(ResourceMetadataStatus status) {
switch (status) {
case UNKNOWN:
return ClientResourceStatus.UNKNOWN;
case DOES_NOT_EXIST:
return ClientResourceStatus.DOES_NOT_EXIST;
case REQUESTED:
return ClientResourceStatus.REQUESTED;
case ACKED:
return ClientResourceStatus.ACKED;
case NACKED:
return ClientResourceStatus.NACKED;
default:
throw new AssertionError("Unexpected ResourceMetadataStatus: " + status);
}
}

To use new TIMEOUT status we need to do some envoy and xds proto syncs that will take some time.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful to describe why you are reverting something.

@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 17, 2025
@shivaspeaks shivaspeaks merged commit 6935d3a into master Jul 17, 2025
18 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants