Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base images used for tests to golang:1.20. #385

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

paulosjca
Copy link
Collaborator

@paulosjca paulosjca commented Sep 15, 2023

grpc-go requires go1.19. Infrastructure will be updated separately.

@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Sep 15, 2023
@paulosjca paulosjca self-assigned this Sep 15, 2023
@paulosjca paulosjca added the bug Something isn't working label Sep 15, 2023
Copy link

@wanlindu wanlindu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update go.mod for this change?

@paulosjca
Copy link
Collaborator Author

Do we need to update go.mod for this change?

No, this is not changing anything in the infrastructure, only in the base images used for tests. The go.mod specifies the minimal go version required to build the infrastructure, this change updates the go version actually used to build grpc-go.

@paulosjca paulosjca merged commit 0ef5cfa into grpc:master Sep 15, 2023
1 check passed
@paulosjca paulosjca deleted the driver branch September 15, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants