Use driver from gRPC core 1.60.0 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lepistone
force-pushed
the
fix-driver-build
branch
from
eca4075
to
a87a711
Compare
paulosjca
added
bug
paulosjca
reviewed
Mar 13, 2024
This is the same image used in grpc#388. It upgrades bazel from 6.1.2 to 6.4.0, which is the default supported version starting with v1.60.0. Without this change, building the driver image fails with: /tmp/build_output/5e0c6d2c26e81c9358486406038ccc44/external/com_google_protobuf/upb_generator/BUILD:266:21: @com_google_protobuf//upb_generator:protoc-gen-upb_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule https://github.com/grpc/grpc/blob/master/.bazelversion https://github.com/grpc/grpc/blob/master/bazel/supported_versions.txt
lepistone
force-pushed
the
fix-driver-build
branch
from
a87a711
to
9bc72d2
Compare
paulosjca
approved these changes
Mar 18, 2024
paulosjca
pushed a commit
to paulosjca/test-infra
that referenced
this pull request
Mar 18, 2024
* Update bazel build image for the driver This is the same image used in grpc#388. It upgrades bazel from 6.1.2 to 6.4.0, which is the default supported version starting with v1.60.0. Without this change, building the driver image fails with: /tmp/build_output/5e0c6d2c26e81c9358486406038ccc44/external/com_google_protobuf/upb_generator/BUILD:266:21: @com_google_protobuf//upb_generator:protoc-gen-upb_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule https://github.com/grpc/grpc/blob/master/.bazelversion https://github.com/grpc/grpc/blob/master/bazel/supported_versions.txt * Use the latest released driver, from grpc/grpc 1.62.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for using a driver that contains the fix grpc/grpc#35384.
There are no releases yet that contain the fix, but at least we can start by getting the latest and fixing the related problems.
There is in fact a pre-release with the fixed driver: v1.61.0-pre1.
Once this fix is merged, the fixed driver can be built by setting
DRIVER_VERSIONtov1.61.0-pre1ormaster.