Belt Subsystem with sensors #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaswa999
requested review from
0aax,
6kn4eakfr4s,
siyoyoCode and
CrolineCrois
and removed request for
0aax
6kn4eakfr4s
reviewed
Nov 21, 2024
|
No, its in the RobotContainer to stop and start
|
in breakRoller, first set speed to 0 to stop
CrolineCrois
reviewed
Dec 3, 2024
| mechController.square().onTrue(new InstantCommand(() -> { | ||
| if (beltSwitch.get()) { | ||
| beltSubsystem.breakRoller(true); | ||
| ; |
There was a problem hiding this comment.
is this semicolon supposed to be here
CrolineCrois
reviewed
Dec 3, 2024
| public BeltSubsystem() { | ||
|
|
||
| mainBeltMotor = new WPI_TalonSRX(3); | ||
| mainBeltMotor.setNeutralMode(NeutralMode.Coast); // turning braking to Coast |
There was a problem hiding this comment.
You probably want the roller to be perma on brake. Otherwise the gamepiece might slip out.
CrolineCrois
reviewed
Dec 3, 2024
| beltSubsystem.setBelt(0.2); | ||
|
|
||
| })); | ||
|
|
There was a problem hiding this comment.
you will want an option to run the belt backwards in case of unforseen circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has subsystem for Belt, uses sensors as well