Skip to content

Refactor: Move private methods to anonymous namespace #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged

Conversation

grunt-lucas
Copy link
Owner

Summary

  • Moved private helper methods from class implementations to anonymous namespaces in their respective .cpp files
  • Removed extensive private method documentation from header files to improve readability
  • Cleaned up constructor parameter const qualifiers for better consistency

Changes

  • ProjectCSourceFileAppender: Moved AppendToFile, ReadFile, and WriteFile methods to anonymous namespace
  • TextualCSourceGenerator: Moved utility methods like ToLowercaseFilePath, GeneratePaletteIncludeLine, etc. to anonymous namespace
  • Removed detailed private method documentation from header files
  • Updated constructor parameter from const gsl::not_null<ProjectPaths *> to gsl::not_null<ProjectPaths *>

Benefits

  • Cleaner header files with focus on public interface
  • Better encapsulation of implementation details
  • Follows project style guidelines for private helper functions
  • Maintains all existing functionality while improving code organization

🤖 Generated with Claude Code

@grunt-lucas grunt-lucas added refactoring Code cleanup that doesn't significantly alter functionality porytiles2 Work related to the Porytiles 2 effort labels Jul 12, 2025
@grunt-lucas grunt-lucas merged commit 8f2a393 into develop Jul 12, 2025
5 checks passed
@grunt-lucas grunt-lucas deleted the 2/cleanup branch July 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porytiles2 Work related to the Porytiles 2 effort refactoring Code cleanup that doesn't significantly alter functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant