fix: extend resource naming check to all providers#1041
Open
james00012 wants to merge 2 commits intomasterfrom
Open
fix: extend resource naming check to all providers#1041james00012 wants to merge 2 commits intomasterfrom
james00012 wants to merge 2 commits intomasterfrom
Conversation
- Add empty CONFIG_BLOCK guard to prevent silent false-pass if the Config struct signature changes or config.go is malformed - Add scanning output showing which directories are checked for easier debugging
james00012
force-pushed
the
check-resource-naming-gcp
branch
from
858f5e2 to
16e66c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-resource-naming.shonly validated AWS resources. Now dynamically discovers all<provider>/resources/directories so GCP (and future providers) are covered automatically.set -euo pipefail.Test plan
bash scripts/check-resource-naming.shpasses and reports 121 resource types + 128 YAML tags