fix: aggregate nuke errors and propagate context#1045
Open
james00012 wants to merge 3 commits intomasterfrom
Open
fix: aggregate nuke errors and propagate context#1045james00012 wants to merge 3 commits intomasterfrom
james00012 wants to merge 3 commits intomasterfrom
Conversation
Previously NukeAllResources silently discarded per-region errors. Now errors are aggregated via multierror and returned to the caller. Also threads context through to individual Nuke calls and broadens throttle detection to cover ThrottlingException and TooManyRequestsException.
…atching Replace fragile strings.Contains() throttling checks with structured error code matching via the new util.IsThrottlingError() helper, consistent with the existing pattern in util/error.go.
james00012
force-pushed
the
jk/nuke-error-aggregation
branch
from
e755459 to
c6a6a74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NukeAllResourcesandnukeAllResourcesInRegionnow collect per-region nuke errors viahashicorp/go-multierrorand return them to the caller, instead of silently discarding them.context.Contextfrom the CLI layer throughNukeAllResources→nukeAllResourcesInRegion→ individualNukecalls, replacing the previouscontext.TODO().ThrottlingExceptionandTooManyRequestsExceptionin addition toRequestLimitExceeded.Test plan
go build ./...andgo vet ./...pass