fix: add safety checks and filtering to resource operations#1046
Open
james00012 wants to merge 2 commits intomasterfrom
Open
fix: add safety checks and filtering to resource operations#1046james00012 wants to merge 2 commits intomasterfrom
james00012 wants to merge 2 commits intomasterfrom
Conversation
- Add nil checks in tag conversion helpers to prevent panics - Add ShouldInclude filtering to SageMaker Studio lister - Add timeout and context check to IAM SLR deletion polling - Warn instead of error for unsupported GCP resource-type flags - Add explanatory comment for GCS bucket panic recovery
Replace hand-rolled polling loop with the shared PollUntil utility, which handles context cancellation, timeout, and interval properly.
james00012
force-pushed
the
jk/resource-safety-fixes
branch
from
efef054 to
ecf4684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
util/tag.go) to prevent panics on nil Key/ValueShouldIncludefiltering to SageMaker Studio domain lister (was appending unconditionally)ConfigGetterto pass fullResourceTypeinstead of partial copyutil.PollUntilhelper--resource-typeflags are passed to GCP commandsTest plan
go build ./...passesgo vet ./...passesgolangci-lintpassesgo test ./aws/... ./util/... ./commands/... -short)