fix: replace deprecated tag field in config example#1047
Open
james00012 wants to merge 2 commits intomasterfrom
Open
fix: replace deprecated tag field in config example#1047james00012 wants to merge 2 commits intomasterfrom
james00012 wants to merge 2 commits intomasterfrom
Conversation
The `tag` field was removed from FilterRule in a recent refactor, so `tag: test` entries in the example config were silently ignored. Replace all 232 occurrences with the correct `tags:` map syntax.
The deprecated `tag: test` specified a tag key, not value. The correct
replacement is `tags: { test: "true" }` (key=test, value=true), not
`tags: { Environment: "^test.*$" }`.
james00012
force-pushed
the
jk/fix-config-example
branch
from
19df27b to
4b43c39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag: testfield with the correcttags:map syntax inconfig/examples/complete.yamltagandtag_valuefields were removed fromFilterRulein a recent refactor, so the old entries were silently ignored during YAML parsingTest plan
python3 -c "import yaml; yaml.safe_load(open('config/examples/complete.yaml'))"tag: testoccurrencestags:map entries with correct indentation