Add cleanup step for new comment-updating strategy #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachGoldberg
commented
Jun 22, 2024
| @@ -31,7 +31,7 @@ on: | |||
|
|
|||
| env: | |||
| PIPELINES_CLI_VERSION: v0.10.1 | |||
| PIPELINES_ACTIONS_VERSION: v1.3.3 | |||
| PIPELINES_ACTIONS_VERSION: mutexspike | |||
There was a problem hiding this comment.
TODO - Update once actions PR (https://github.com/gruntwork-io/pipelines-actions/pull/24) is merged
|
We should hold off on merging this until we spike on the updated upload/download strategy which has the potential to remove the need for the cleanup step entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new cleanup step is necessary to ensure comments get an accurate state at the end of the run, it ensures any errors/omissions due to race conditions in the matrix related to comments don't hang around.