-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: move abi checks to a feature and build the C code at build time #1052
base: main
Are you sure you want to change the base?
Conversation
Seems like a good idea |
cead587
to
16d60f7
Compare
This currently fails for gdk-pixbuf due to gdesmott/system-deps#28 With regard to Windows CI, the good news is that this approach works and the C programs are compiled and the layout test work, the bad news is the MSVC does not support |
It's available since Visual Studio 2019 version 16.7.0 from what I can see, and you can enable it via |
Actually it seems that the Visual Studio version is new enough and does have
|
That means we have |
the problem is that we have:
so we are printing them differently |
Ah that's annoying and otherwise needs conditional compilation for platforms where signed or unsigned chars are the default... |
OTOH, only the two cases (signed / unsigned) should be there. |
That has helped, but now it complains about not finding |
The abi tests are now conditional to the abi-tests feature, when that is enabled, the C code for the abi tests is now built at compile time, using the cc crate rather than having our own Compiler abstraction and having to compile stuff at runtime and deal with temp directories etc.
We explicitely handle signed and unsigned, and some compilers (MSVC) do not like duplicate types.
fc9de62
to
7b0ff6d
Compare
The abi tests are now conditional to the abi-tests feature,
when that is enabled, the C code for the abi tests is now built
at compile time, using the cc crate rather than having our own
Compiler abstraction and having to compile stuff at runtime and
deal with temp directories etc.